monrg commented on code in PR #1738:
URL:
https://github.com/apache/incubator-streampark/pull/1738#discussion_r989112726
##########
streampark-flink/streampark-flink-proxy/src/main/scala/org/apache/streampark/flink/proxy/FlinkShimsProxy.scala:
##########
@@ -88,10 +88,17 @@ object FlinkShimsProxy extends Logger {
SHIMS_CLASS_LOADER_CACHE.getOrElseUpdate(s"${flinkVersion.fullVersion}", {
// 1) flink/lib
- val libURL = getFlinkHomeLib(flinkVersion.flinkHome)
- val shimsUrls = ListBuffer[URL](libURL: _*)
+ def filterLib(filterLib: File): Boolean = {
+ !(filterLib.getName.startsWith("log4j") ||
filterLib.getName.startsWith("flink-table-planner-loader"))
Review Comment:
Thank you for your feedback，because ExecutorFactory has two implementation:
DefaultExecutorFactory(flink-table-planer) and
DelegateExecutorFactory(flink-table-planer-loader), spi load 2 servi will
conflict, When flink 1.15 running the process is loaded through
DelegateExecutorFactory by DefaultExecutorFactory, so exclude
flink-table-planer-loader to add flink-table-planer to classpath, this scheme
is relatively simple, and later will study whether there can be a better way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
