[GitHub] [incubator-streampark] monrg commented on a diff in pull request #1757: [Improve] Improve the module list

Fri, 07 Oct 2022 00:34:02 -0700 


monrg commented on code in PR #1757:
URL: 
https://github.com/apache/incubator-streampark/pull/1757#discussion_r989777034


##########
streampark-flink/streampark-flink-connector/pom.xml:
##########
@@ -48,6 +48,7 @@
         <module>streampark-flink-connector-jdbc</module>
         <module>streampark-flink-connector-kafka</module>
         <module>streampark-flink-connector-mongo</module>
+        <module>streampark-flink-connector-redis</module>

Review Comment:
   Hi @1996fanrui , thanks for your clarification.Since 
StreamPark-Flink-connector-Redis relies on Flink-connector-Redis, which only 
provides scala2.11, this module is excluded from the Module list.
   
![image](https://user-images.githubusercontent.com/45427129/194497802-0d5e19c8-c7c0-47bf-828b-c0303eb7fde6.png)
   



##########
streampark-flink/pom.xml:
##########
@@ -41,6 +41,7 @@
         <module>streampark-flink-proxy</module>
         <module>streampark-flink-packer</module>
         <module>streampark-flink-kubernetes</module>
+        <module>streampark-flink-repl</module>

Review Comment:
   Hi @1996fanrui , thanks for your clarification.Streampark-flink-repl is now 
an experimental module that the original implementation would have depended on 
Checkstyle violation. Therefore, it is not added to Module list for the time 
being, and the whole package is passed
   
![image](https://user-images.githubusercontent.com/45427129/194497103-3833bb79-591d-4b53-937f-bcd754364691.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to