wolfboys commented on code in PR #1738:
URL:
https://github.com/apache/incubator-streampark/pull/1738#discussion_r990047227
##########
streampark-flink/streampark-flink-proxy/src/main/scala/org/apache/streampark/flink/proxy/FlinkShimsProxy.scala:
##########
@@ -88,10 +88,17 @@ object FlinkShimsProxy extends Logger {
SHIMS_CLASS_LOADER_CACHE.getOrElseUpdate(s"${flinkVersion.fullVersion}", {
// 1) flink/lib
- val libURL = getFlinkHomeLib(flinkVersion.flinkHome)
- val shimsUrls = ListBuffer[URL](libURL: _*)
+ def filterLib(filterLib: File): Boolean = {
Review Comment:
Difficult to read, It is recommended change to this:
`!lib.getName.startsWith("log4j") &&
!lib.getName.startsWith("flink-table-planner-loader")`
##########
streampark-flink/streampark-flink-proxy/src/main/scala/org/apache/streampark/flink/proxy/FlinkShimsProxy.scala:
##########
@@ -130,10 +137,10 @@ object FlinkShimsProxy extends Logger {
})
}
- private[this] def getFlinkHomeLib(flinkHome: String): List[URL] = {
Review Comment:
The method name can be improved, how about `getFlinkLib` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
