wolfboys commented on code in PR #1811:
URL:
https://github.com/apache/incubator-streampark/pull/1811#discussion_r992475688
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/base/exception/ApiAlertException.java:
##########
@@ -26,18 +28,22 @@
* ...
* </pre>
*/
-public class ApiAlertException extends RuntimeException {
+public class ApiAlertException extends AbstractApiException {
public ApiAlertException(String message) {
- super(message);
+ super(message, ResponseCode.CODE_FAIL_ALERT);
}
public ApiAlertException(Throwable cause) {
- super(cause);
+ super(cause, ResponseCode.CODE_FAIL_ALERT);
}
public ApiAlertException(String message, Throwable cause) {
- super(message, cause);
+ super(message, cause, ResponseCode.CODE_FAIL_ALERT);
}
+ @Override
+ public String getNotificationMessagePrefix() {
+ return "Alert exception: ";
Review Comment:
oh, I didn't express clearly, `ApiAlertException` is presented directly to
the front-end alert, I think there is no need for any prefix, because the
message of the alert is already a clear message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
