wolfboys commented on code in PR #1831: URL: https://github.com/apache/incubator-streampark/pull/1831#discussion_r994839182
########## streampark-console/streampark-console-service/src/assembly/script/schema/mysql-schema.sql: ########## @@ -319,6 +319,24 @@ create table `t_team` ( unique key `team_name_idx` (`team_name`) using btree ) engine = innodb default charset = utf8mb4 collate = utf8mb4_general_ci; +-- ---------------------------- +-- Table of t_variable +-- ---------------------------- +drop table if exists `t_variable`; +create table `t_variable` ( + `id` bigint not null auto_increment, + `variable_code` varchar(100) collate utf8mb4_general_ci not null comment 'variable code', Review Comment: about `comment` could it be clearer? ########## streampark-console/streampark-console-service/src/assembly/script/upgrade/mysql/1.2.4.sql: ########## @@ -201,5 +205,21 @@ alter table `t_user` modify `username` varchar(255) collate utf8mb4_general_ci not null comment 'user name', add unique key `un_username` (`username`) using btree; +drop table if exists `t_variable`; +create table `t_variable` ( + `id` bigint not null auto_increment, + `variable_code` varchar(100) collate utf8mb4_general_ci not null comment 'variable code', + `variable_value` varchar(1024) collate utf8mb4_general_ci not null comment 'variable value', Review Comment: Suggest change type to: text ########## streampark-console/streampark-console-service/src/assembly/script/schema/mysql-schema.sql: ########## @@ -319,6 +319,24 @@ create table `t_team` ( unique key `team_name_idx` (`team_name`) using btree ) engine = innodb default charset = utf8mb4 collate = utf8mb4_general_ci; +-- ---------------------------- +-- Table of t_variable +-- ---------------------------- +drop table if exists `t_variable`; +create table `t_variable` ( + `id` bigint not null auto_increment, + `variable_code` varchar(100) collate utf8mb4_general_ci not null comment 'variable code', + `variable_value` varchar(1024) collate utf8mb4_general_ci not null comment 'variable value', Review Comment: Suggest change type to: text -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
