1996fanrui commented on code in PR #1831: URL: https://github.com/apache/incubator-streampark/pull/1831#discussion_r996374019
########## streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/entity/Variable.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.streampark.console.system.entity; + +import com.baomidou.mybatisplus.annotation.IdType; +import com.baomidou.mybatisplus.annotation.TableId; +import com.baomidou.mybatisplus.annotation.TableName; +import lombok.Data; + +import javax.validation.constraints.NotBlank; +import javax.validation.constraints.NotNull; +import javax.validation.constraints.Size; + +import java.io.Serializable; +import java.util.Date; + +@Data +@TableName("t_variable") +public class Variable implements Serializable { + + private static final long serialVersionUID = -7720746591258904369L; + + @TableId(type = IdType.AUTO) + private Long id; + + @NotBlank(message = "{required}") + private String variableCode; + + @NotBlank(message = "{required}") + @Size(max = 50, message = "{noMoreThan}") + private String variableValue; + + @Size(max = 100, message = "{noMoreThan}") + private String description; + + private Long creator; Review Comment: > It needs to be consistent with other tables Sorry, I cannot get any advantage. The creator is the really business mean at here. User id is just the value. If the field name is userId, it's not clear. Other develops don't know what is the relationship between user id and variables? Creator is more clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
