lvshaokang commented on code in PR #1840:
URL:
https://github.com/apache/incubator-streampark/pull/1840#discussion_r996447644
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/PassportController.java:
##########
@@ -102,6 +109,46 @@ public RestResponse signin(
return new RestResponse().data(userInfo);
}
+ @PostMapping("signinbycasdoor")
+ public RestResponse signinByCasdoor(@NotBlank(message = "{required}")
String code,
+ @NotBlank(message = "{required}")
String state) throws Exception {
+ String token = "";
Review Comment:
It is not recommended to throw Exception directly, but rather to handle them
on a case-by-case basis.
##########
streampark-console/streampark-console-service/pom.xml:
##########
@@ -383,6 +383,12 @@
<version>${swagger.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.casbin</groupId>
+ <artifactId>casdoor-spring-boot-starter</artifactId>
+ <version>1.5.1</version>
Review Comment:
Please extract version to <properties/> frame
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
