wolfboys commented on code in PR #1860:
URL:
https://github.com/apache/incubator-streampark/pull/1860#discussion_r997633812
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/service/impl/UserServiceImpl.java:
##########
@@ -159,9 +160,14 @@ public void resetPassword(String[] usernames) {
* @return permissions
*/
@Override
- public Set<String> getPermissions(String username) {
- List<Menu> permissionList =
this.menuService.findUserPermissions(username);
- return
permissionList.stream().map(Menu::getPerms).collect(Collectors.toSet());
+ public Set<String> getAllTeamPermissions(String username) {
Review Comment:
`getPermissions` method can replaced `getAllTeamPermissions` method, we
don't need this method, What do you think?
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/service/UserService.java:
##########
@@ -103,7 +105,16 @@ public interface UserService extends IService<User> {
*/
void resetPassword(String[] usernames) throws Exception;
- Set<String> getPermissions(String username);
+ Set<String> getAllTeamPermissions(String username);
Review Comment:
I don't think it's necessary to add this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
