wolfboys commented on code in PR #1915:
URL:
https://github.com/apache/incubator-streampark/pull/1915#discussion_r1006487499
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/VariableServiceImpl.java:
##########
@@ -138,26 +157,38 @@ public String replaceVariable(Long teamId, String mixed) {
}
private boolean isDependByApplications(Variable variable) {
- // Detect whether the variable is dependent on the args of the
application
+ if (CollectionUtils.isEmpty(getDependApplicationsByCode(variable))) {
+ return false;
+ }
+ return true;
Review Comment:
Code could be simpler:
```
return CollectionUtils.isNotEmpty(getDependApplicationsByCode(variable));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
