1996fanrui commented on code in PR #1910:
URL: 
https://github.com/apache/incubator-streampark/pull/1910#discussion_r1007073467


##########
streampark-console/streampark-console-service/src/main/resources/application.yml:
##########
@@ -91,6 +91,8 @@ streampark:
   workspace:
     local: /opt/streampark_workspace
     remote: hdfs://hdfscluster/streampark   # support hdfs:///streampark/ 、 
/streampark 、hdfs://host:ip/streampark/
+  archive:
+    path: hdfs:///streampark/completed-jobs/

Review Comment:
   If so, we shouldn't use a new directory every time we need to use remote 
storage. A reasonable solution is : `workspace.remote` should support various 
storages, and `archive.path` should under the `workspace.remote`.
   
   In summary: we should use `workspace.remote` uniformly, and in the future, 
do lifecycle management for all directories under `workspace.local` and 
workspace.remote`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to