1996fanrui commented on code in PR #1910:
URL:
https://github.com/apache/incubator-streampark/pull/1910#discussion_r1009057980
##########
streampark-common/src/main/scala/org/apache/streampark/common/conf/Workspace.scala:
##########
@@ -41,22 +41,27 @@ object Workspace {
/**
* dirPath of the maven local repository with built-in compilation process
*/
- lazy val MAVEN_LOCAL_DIR = s"$localWorkspace/mvnrepo"
+ lazy val MAVEN_LOCAL_PATH = s"$localWorkspace/mvnrepo"
/**
- * local sourceCode dir.(for git...)
+ * local sourceCode path.(for git...)
*/
- lazy val PROJECT_LOCAL_DIR = s"$localWorkspace/project"
+ lazy val PROJECT_LOCAL_PATH = s"$localWorkspace/project"
/**
- * local log dir.
+ * local log path.
*/
- lazy val LOG_LOCAL_DIR = s"$localWorkspace/logs"
+ lazy val LOG_LOCAL_PATH = s"$localWorkspace/logs"
/**
- * project build log dir.
+ * project build log path.
*/
- lazy val PROJECT_BUILD_LOG_DIR = s"$LOG_LOCAL_DIR/build_logs"
+ lazy val PROJECT_BUILD_LOG_PATH = s"$LOG_LOCAL_PATH/build_logs"
+
+ /**
+ * project archives path
+ */
+ lazy val ARCHIVES_FILE_PATH = s"$localWorkspace/historyserver/archive"
Review Comment:
@wolfboys why do you change it to the `localWorkspace`? As I understand, it
should be the `remoteWorkspace`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
