1996fanrui commented on code in PR #2268:
URL:
https://github.com/apache/incubator-streampark/pull/2268#discussion_r1103634516
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/CheckpointProcessor.java:
##########
@@ -41,9 +44,16 @@
@Component
public class CheckpointProcessor {
+ private static final Byte DEFAULT_FLAG_BYTE = Byte.valueOf("0");
+ private static final Integer SAVEPOINT_CACHE_HOUR = 1;
+
private final Cache<String, Long> checkPointCache =
Caffeine.newBuilder().expireAfterAccess(1, TimeUnit.DAYS).build();
+ /** Cache to store the savepoint path if be stored in the db. */
+ private final Cache<String, Byte> savepointedCache =
Review Comment:
Thanks for your quick clarification.
> However, if the savepoint store-logic follow checkpoint, here would be
some bug-case. If the triggered savepoint is completed after a completed
checkpoint whose chk-id is bigger than the savepoint, the savepoint will be
discard based on the current logic.
As I understand, you have ordered the checkpoint by chk-id, so the bug
cannot be happened when `execution.checkpointing.max-concurrent-checkpoints ==
1` due to the `checkpoint/savepoint` with a smaller `chk-id` must be completed
earlier than the checkpoint with a larger `chk-id`, right?
Are you worried about `execution.checkpointing.max-concurrent-checkpoints >
1`?
And I mean the code is a bit complicated right now, not sure if it's
necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
