[GitHub] [incubator-streampark] GOODBOY008 opened a new issue, #2594: [Feature] Use DTO inster and use validator to validate request params.

[via GitHub]

GOODBOY008 opened a new issue, #2594:
URL: https://github.com/apache/incubator-streampark/issues/2594

   ### Search before asking
   
   - [X] I had searched in the 
[feature](https://github.com/apache/incubator-streampark/issues?q=is%3Aissue+label%3A%22Feature%22)
 and found no similar feature requirement.
   
   
   ### Description
   
   Like 
`org.apache.streampark.console.core.controller.ApplicationController#cancel` 
from controller method , developer can not know what params pass from front end 
and param validation is missing(cann`t understand which param should not be 
null).
   <img width="571" alt="企业微信截图_16810354379483" 
src="https://user-images.githubusercontent.com/13617900/230767175-70887552-1fe8-4464-adb0-da9ead36393c.png";>
   <img width="445" alt="企业微信截图_16810361455091" 
src="https://user-images.githubusercontent.com/13617900/230767623-8ef1e97d-bbfc-4a44-b29d-ca9d6a32df3a.png";>
   
   But we change `Application` to `ApplicationCancelDTO`  and add validation. 
It will be very clear for develpoer and can block bad request with invalidate 
params.
   <img width="581" alt="企业微信截图_16810358813668" 
src="https://user-images.githubusercontent.com/13617900/230767427-4f09f76c-4f76-45ca-acd3-ae98c3f2aa2a.png";>
   <img width="277" alt="企业微信截图_1681035905236" 
src="https://user-images.githubusercontent.com/13617900/230767457-df85f257-b910-43ff-b6ba-499fa64c87e1.png";>
   
   
   ### Usage Scenario
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@streampark.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org