RocMarshal commented on code in PR #2826:
URL:
https://github.com/apache/incubator-streampark/pull/2826#discussion_r1249557999
##########
streampark-console/streampark-console-service/src/main/resources/mapper/core/ApplicationMapper.xml:
##########
@@ -133,7 +133,7 @@
limit 1
</select>
- <select id="getAffectedJobsByClusterId" resultType="java.lang.Integer"
parameterType="java.lang.Long">
+ <select id="countJobsByClusterId" resultType="java.lang.Integer"
parameterType="java.lang.Long">
select
count(1)
from t_flink_app
Review Comment:
Do we need to filter the status of the application here?
https://github.com/apache/incubator-streampark/pull/2809#discussion_r1242367682
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/FlinkClusterWatcher.java:
##########
@@ -321,11 +251,9 @@ private FinalApplicationStatus
stringConvertFinalApplicationStatus(String value)
* @return
*/
private ClusterState
finalApplicationStatusConvertClusterState(FinalApplicationStatus status) {
- switch (status) {
- case UNDEFINED:
- return ClusterState.RUNNING;
- default:
- return ClusterState.STOPPED;
+ if (status == FinalApplicationStatus.UNDEFINED) {
Review Comment:
When the yarn application was accepted by yarn resourcemanager, the
FinalApplicationStatus is `UNDEFINED` too, but the flink cluster isn't `RUNNING`
This case was mentioned in
https://github.com/apache/incubator-streampark/pull/2541#discussion_r1162899796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
