wolfboys commented on code in PR #2826:
URL:
https://github.com/apache/incubator-streampark/pull/2826#discussion_r1249570377
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/FlinkClusterWatcher.java:
##########
@@ -321,11 +251,9 @@ private FinalApplicationStatus
stringConvertFinalApplicationStatus(String value)
* @return
*/
private ClusterState
finalApplicationStatusConvertClusterState(FinalApplicationStatus status) {
- switch (status) {
- case UNDEFINED:
- return ClusterState.RUNNING;
- default:
- return ClusterState.STOPPED;
+ if (status == FinalApplicationStatus.UNDEFINED) {
Review Comment:
> When the yarn application was accepted by yarn resourcemanager, the
FinalApplicationStatus is `UNDEFINED` too, but the flink cluster isn't `RUNNING`
>
> This case was mentioned in [#2541
(comment)](https://github.com/apache/incubator-streampark/pull/2541#discussion_r1162899796)
I also have questions about this logic and further discussion is needed.
@xujiangfeng001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
