xujiangfeng001 commented on code in PR #2826:
URL:
https://github.com/apache/incubator-streampark/pull/2826#discussion_r1257659800
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/FlinkClusterWatcher.java:
##########
@@ -168,13 +135,29 @@ private void alert(FlinkCluster cluster, ClusterState
state) {
* @param flinkCluster
* @return
*/
- private ClusterState getClusterState(FlinkCluster flinkCluster) {
- ClusterState state = getClusterStateFromFlinkAPI(flinkCluster);
- if (ClusterState.isRunningState(state)) {
+ public ClusterState getClusterState(FlinkCluster flinkCluster) {
+ ClusterState state = FAILED_STATES.getIfPresent(flinkCluster.getId());
Review Comment:
I think there is a problem with the logic in this method: here, in Yarn
Session mode, it won't go `jobmanagerUrl `request status, only `yarn restful
api` requests will be processed. This is not in line with our original
intention of designing the `jobmanagerUrl` field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
