Al-assad commented on code in PR #2916:
URL: 
https://github.com/apache/incubator-streampark/pull/2916#discussion_r1284019489


##########
streampark-common/pom.xml:
##########
@@ -128,6 +128,32 @@
             <version>${streampark.shaded.version}</version>
         </dependency>
 
+        <!-- ZIO -->
+        <dependency>

Review Comment:
   The interfaces exposed by streampark-flink-kubernetes are all zio or zstream 
structures, and external calls must refer to zio. I'll be writing more zio code 
in other modules later on.ZIO is a basic, pure-scala, zero-dependency library, 
so placing it in comon doesn't seem like a problem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to