Al-assad commented on code in PR #2922:
URL:
https://github.com/apache/incubator-streampark/pull/2922#discussion_r1284121893
##########
streampark-common/src/main/scala/org/apache/streampark/common/zio/ZIOLogger.scala:
##########
@@ -73,6 +73,7 @@ object LoggerBackend {
case LogLevel.Warning => logger.warn(msg)
case LogLevel.Error => logger.error(msg)
case LogLevel.Fatal => logger.error(msg)
+ case _ => logger.error(msg)
Review Comment:
All cases of ZIO.logging.LogLevel are already included here, the remaining
matches are not necessary,. If you force a remaining match, it is safer to
match to `logger.trace`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
