wolfboys commented on code in PR #2943:
URL:
https://github.com/apache/incubator-streampark/pull/2943#discussion_r1294238464
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ResourceServiceImpl.java:
##########
@@ -284,7 +285,7 @@ public RestResponse checkResource(Resource resourceParam)
throws JsonProcessingE
Manifest manifest = Utils.getJarManifest(jarFile);
String mainClass = manifest.getMainAttributes().getValue("Main-Class");
- if (mainClass == null) {
+ if (mainClass == null &&
StringUtils.isBlank(resourceParam.getMainClass())) {
Review Comment:
oh no, The main-class must be parseable from the user's flink app, otherwise
it is an invalid flink app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
