wolfboys commented on code in PR #2875:
URL:
https://github.com/apache/incubator-streampark/pull/2875#discussion_r1295233611
##########
streampark-common/src/main/java/org/apache/streampark/common/enums/ClusterState.java:
##########
@@ -32,7 +32,7 @@ public enum ClusterState implements Serializable {
/** cluster unknown */
UNKNOWN(4),
STARTING(5),
- CANCELING(6),
+ CANCELLING(6),
Review Comment:
These values are too arbitrary. We can set the status according to certain
rules, such as from "create" to "start" to "stop", and then list some status of
each stage, e.g:
```
CREATED(0),
STARTING(1),
RUNNING(2),
CANCELLING(3),
CANCELED(4),
FAILED(5),
KILLED(6);
LOST(7),
UNKNOWN(8)
```
##########
streampark-console/streampark-console-webapp/src/enums/flinkEnum.ts:
##########
@@ -140,11 +140,17 @@ export enum ClusterStateEnum {
/** The cluster was just created but not started */
CREATED = 0,
/** cluster started */
- STARTED = 1,
+ RUNNING = 1,
/** cluster canceled */
CANCELED = 2,
/** cluster lost */
LOST = 3,
+ /** cluster unknown */
+ UNKNOWN = 4,
+ STARTING = 5,
Review Comment:
These values are too arbitrary. We can set the status according to certain
rules, such as transitioning from "create" to "start" to "stop." and then list
some status of each stage, which would be better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
