wuchunfu commented on code in PR #3264:
URL:
https://github.com/apache/incubator-streampark/pull/3264#discussion_r1367909856
##########
streampark-common/src/main/scala/org/apache/streampark/common/util/YarnUtils.scala:
##########
@@ -127,8 +128,8 @@ object YarnUtils extends Logger {
val conf = HadoopUtils.hadoopConf
val useHttps = YarnConfiguration.useHttps(conf)
val (addressPrefix, defaultPort, protocol) = useHttps match {
- case x if x => (YarnConfiguration.RM_WEBAPP_HTTPS_ADDRESS, "8090",
"https://";)
- case _ => (YarnConfiguration.RM_WEBAPP_ADDRESS, "8088", "http://";)
+ case x if x => (YarnConfiguration.RM_WEBAPP_HTTPS_ADDRESS, "8090",
Constant.HTTPS_SCHEMA)
+ case _ => (YarnConfiguration.RM_WEBAPP_ADDRESS, "8088",
Constant.HTTP_SCHEMA)
Review Comment:
Hi, @RocMarshal it is recommended that the port number here be extracted as
a constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
