RocMarshal commented on code in PR #3304:
URL:
https://github.com/apache/incubator-streampark/pull/3304#discussion_r1379035244
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/service/UserService.java:
##########
@@ -106,7 +106,7 @@ public interface UserService extends IService<User> {
void fillInTeam(User user);
- List<User> findByAppOwner(Long teamId);
+ List<User> listByAppOwner(Long teamId);
Review Comment:
how about `listByTeamId`
##########
streampark-console/streampark-console-service/src/test/java/org/apache/streampark/console/core/service/AccessTokenServiceTest.java:
##########
@@ -55,18 +55,18 @@ void testCrudToken() throws Exception {
String username = JWTUtil.getUserName(jwtToken.getToken());
Assertions.assertNotNull(username);
Assertions.assertEquals("admin", username);
- User user = userService.findByName(username);
+ User user = userService.getByName(username);
Review Comment:
how about `getByUsername` or `getByUserName` ? (case of cross-services)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
