Al-assad commented on code in PR #3416:
URL:
https://github.com/apache/incubator-streampark/pull/3416#discussion_r1433415681
##########
streampark-flink/streampark-flink-kubernetes/src/main/scala/org/apache/streampark/flink/kubernetes/KubernetesRetriever.scala:
##########
@@ -41,11 +41,11 @@ import scala.util.{Failure, Success, Try}
object KubernetesRetriever extends Logger {
// see org.apache.flink.client.cli.ClientOptions.CLIENT_TIMEOUT}
- val FLINK_CLIENT_TIMEOUT_SEC = 30L
+ val FLINK_CLIENT_TIMEOUT_SEC = 60L
// see org.apache.flink.configuration.RestOptions.AWAIT_LEADER_TIMEOUT
- val FLINK_REST_AWAIT_TIMEOUT_SEC = 10L
+ val FLINK_REST_AWAIT_TIMEOUT_SEC = 30L
// see org.apache.flink.configuration.RestOptions.RETRY_MAX_ATTEMPTS
- val FLINK_REST_RETRY_MAX_ATTEMPTS = 2
+ val FLINK_REST_RETRY_MAX_ATTEMPTS = 30
Review Comment:
I agree with you that this part affects flink task deployment and state
tracking, and the state tracking part has its own additional timeout control
mechanism, and increasing the retry parameter does alleviate the timeout
tolerance of the submitted job.
So, LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
