lenonhere commented on code in PR #3004:
URL:
https://github.com/apache/incubator-streampark/pull/3004#discussion_r1451851156
##########
streampark-flink/streampark-flink-connector/streampark-flink-connector-base/src/test/scala/org/apache/streampark/flink/connector/failover/SinkRequestTest.scala:
##########
@@ -0,0 +1,28 @@
+package org.apache.streampark.flink.connector.failover
+
+import org.junit.jupiter.api.{Assertions, Test}
+
+import scala.collection.JavaConverters._
+
+class SinkRequestTest {
+ @Test
+ def sqlStatement(): Unit = {
+ val statementsList = List(
+ "insert into table_1(col1, col2) values(1, 2)",
+ "insert into table_1(col1, col2) values(11, 22)",
+ "insert into table_1(col1, col2, col3) values(11, 22, 33)",
+ "insert into table_2(col1, col2, col3) values(11, 22, 33)",
+ )
+
+ val sinkRequest = SinkRequest(statementsList.asJava)
+
+ val expectedSqlStatement = List(
+ "insert into table_2(col1, col2, col3) VALUES (11, 22, 33)",
+ "insert into table_1(col1, col2) VALUES (1, 2),(11, 22)",
+ "insert into table_1(col1, col2, col3) VALUES (11, 22, 33)",
Review Comment:
I found the trailing comma in this line will fail to pass the exam by
spotless-maven-plugin.
##########
streampark-flink/streampark-flink-connector/streampark-flink-connector-base/src/test/scala/org/apache/streampark/flink/connector/failover/SinkRequestTest.scala:
##########
@@ -0,0 +1,28 @@
+package org.apache.streampark.flink.connector.failover
+
+import org.junit.jupiter.api.{Assertions, Test}
+
+import scala.collection.JavaConverters._
+
+class SinkRequestTest {
+ @Test
+ def sqlStatement(): Unit = {
+ val statementsList = List(
+ "insert into table_1(col1, col2) values(1, 2)",
+ "insert into table_1(col1, col2) values(11, 22)",
+ "insert into table_1(col1, col2, col3) values(11, 22, 33)",
+ "insert into table_2(col1, col2, col3) values(11, 22, 33)",
Review Comment:
I found the trailing comma in this line will fail to pass the exam by
`spotless-maven-plugin`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
