caicancai commented on code in PR #3493:
URL:
https://github.com/apache/incubator-streampark/pull/3493#discussion_r1456739159
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SavePointServiceImpl.java:
##########
@@ -333,6 +333,16 @@ private void handleSavepointResponseFuture(
if (savepointResponse != null &&
savepointResponse.savePointDir() != null) {
applicationLog.setSuccess(true);
String savePointDir = savepointResponse.savePointDir();
+
+ SavePoint savePoint = new SavePoint();
+ savePoint.setAppId(application.getId());
+ savePoint.setLatest(true);
+ savePoint.setType(CheckPointType.SAVEPOINT.get());
+ savePoint.setCreateTime(new Date());
Review Comment:
createtime and createtime is same?
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SavePointServiceImpl.java:
##########
@@ -333,6 +333,16 @@ private void handleSavepointResponseFuture(
if (savepointResponse != null &&
savepointResponse.savePointDir() != null) {
applicationLog.setSuccess(true);
String savePointDir = savepointResponse.savePointDir();
+
+ SavePoint savePoint = new SavePoint();
Review Comment:
Maybe you can try to optimize this part of the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
