wolfboys commented on code in PR #3723:
URL:
https://github.com/apache/incubator-streampark/pull/3723#discussion_r1613665803
##########
streampark-common/src/main/scala/org/apache/streampark/common/util/Utils.scala:
##########
@@ -71,7 +71,14 @@ object Utils extends Logger {
def getJarManifest(jarFile: File): jar.Manifest = {
Review Comment:
We can make the code more cleaner:
```
import org.apache.streampark.common.util.ImplicitsUtils._
def getJarManifest(jarFile: File): jar.Manifest = {
requireCheckJarFile(jarFile.toURL)
new JarInputStream(new FileInputStream(jarFile)).autoClose(_.getManifest)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@streampark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
