SbloodyS commented on code in PR #3847:
URL:
https://github.com/apache/incubator-streampark/pull/3847#discussion_r1670389900
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SettingServiceImpl.java:
##########
@@ -100,7 +105,31 @@ public MavenConfig getMavenConfig() {
@Override
public DockerConfig getDockerConfig() {
- return DockerConfig.fromSetting();
+ List<Setting> settingList =
settingMapper.querySettingByKeys(Arrays.asList(
Review Comment:
I modified it. However, I feel that using baseMapper here will reduce the
readability and maintainability of the code, since other mapper may be added to
the service in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
