ChengJie1053 commented on code in PR #3952:
URL:
https://github.com/apache/incubator-streampark/pull/3952#discussion_r1712927265
##########
streampark-common/src/main/scala/org/apache/streampark/common/conf/ConfigKeys.scala:
##########
@@ -65,6 +65,23 @@ object ConfigKeys {
val KEY_SPARK_BATCH_DURATION = "spark.batch.duration"
+ val KEY_SPARK_DRIVER_CORES = "spark.driver.cores"
+
+ val KEY_SPARK_DRIVER_MEMORY = "spark.driver.memory"
+
+ val KEY_SPARK_EXECUTOR_INSTANCES = "spark.executor.instances"
+
+ val KEY_SPARK_EXECUTOR_CORES = "spark.executor.cores"
+
+ val KEY_SPARK_EXECUTOR_MEMORY = "spark.executor.memory"
+
+ val KEY_SPARK_DYNAMIC_ALLOCATION_ENABLED = "spark.dynamicAllocation.enabled"
+
+ val KEY_SPARK_DYNAMIC_ALLOCATION_MAX_EXECUTORS =
"spark.dynamicAllocation.maxExecutors"
+
+ def KEY_SPARK_SQL(prefix: String = null): String =
+ s"${Option(prefix).getOrElse("")}sql"
+
/** about config flink */
def KEY_APP_CONF(prefix: String = null): String =
s"${Option(prefix).getOrElse("")}conf"
Review Comment:
Whether flink parameters can be deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
