wolfboys commented on code in PR #3948:
URL:
https://github.com/apache/incubator-streampark/pull/3948#discussion_r1714564753
##########
pom.xml:
##########
@@ -146,6 +147,14 @@
<mockito.version>3.4.6</mockito.version>
<mockito-scala.version>1.17.14</mockito-scala.version>
<assertj.version>3.23.1</assertj.version>
+ <testcontainer.version>1.19.3</testcontainer.version>
+ <zookeeper.version>3.8.0</zookeeper.version>
Review Comment:
Please make sure to declare these dependencies in the
[LICENSE](https://github.com/apache/incubator-streampark/blob/dev/dist-material/release-docs/LICENSE)
##########
pom.xml:
##########
@@ -146,6 +147,14 @@
<mockito.version>3.4.6</mockito.version>
<mockito-scala.version>1.17.14</mockito-scala.version>
<assertj.version>3.23.1</assertj.version>
+ <testcontainer.version>1.19.3</testcontainer.version>
+ <zookeeper.version>3.8.0</zookeeper.version>
Review Comment:
Import ZooKeeper may result in additional dependencies, potentially causing
dependency conflicts. Can you confirm this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
