caicancai commented on PR #3948: URL: https://github.com/apache/incubator-streampark/pull/3948#issuecomment-2290734717
> Thanks for your contribution. There are some minor issues: > > 1. streampark needs to support HA, which is a unique feature of the streampark-console module. As per our architectural design, this feature will depend on the registry module. The registry module is only used by the console. So, The registry module should not be placed under the root module; instead, it should be a submodule of the console. > 2. I don't think it's necessary to manually execute JDBC in the registry module because the console platform already has an ORM framework. Also, the registry module will be packaged into the console module, so there's no need to introduce a complex design to make the project look clearer. > > <img alt="image" width="371" src="https://private-user-images.githubusercontent.com/13284744/358124068-4084f6a3-2784-4eac-a7f4-877c286cad5e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM3MDIyNTMsIm5iZiI6MTcyMzcwMTk1MywicGF0aCI6Ii8xMzI4NDc0NC8zNTgxMjQwNjgtNDA4NGY2YTMtMjc4NC00ZWFjLWE3ZjQtODc3YzI4NmNhZDVlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE1VDA2MDU1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU2OTFlMjBkMmYyY2M1NjQ5NGVkMjYwMWU2NjE3NjQyNTczYzgwNmZkY2I0NGFmYWRiZjhiM2E1MzRmYzYyNDcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.lCwJCrwDatTc6BrY0CPeg3VchX1gXsFj_vLMIooOx6w";> I have a different opinion. We take this opportunity to reconstruct the console module. At present, the coupling of the console module is very exaggerated in my opinion, which is not conducive to the subsequent development of the project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://private-user-images.githubusercontent.com/13284744/358124068-4084f6a3-2784-4eac-a7f4-877c286cad5e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM3MDIyNTMsIm5iZiI6MTcyMzcwMTk1MywicGF0aCI6Ii8xMzI4NDc0NC8zNTgxMjQwNjgtNDA4NGY2YTMtMjc4NC00ZWFjLWE3ZjQtODc3YzI4NmNhZDVlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE1VDA2MDU1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU2OTFlMjBkMmYyY2M1NjQ5NGVkMjYwMWU2NjE3NjQyNTczYzgwNmZkY2I0NGFmYWRiZjhiM2E1MzRmYzYyNDcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.lCwJCrwDatTc6BrY0CPeg3VchX1gXsFj_vLMIooOx6w"](https://private-user-images.githubusercontent.com/13284744/358124068-4084f6a3-2784-4eac-a7f4-877c286cad5e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM3MDIyNTMsIm5iZiI6MTcyMzcwMTk1MywicGF0aCI6Ii8xMzI4NDc0NC8zNTgxMjQwNjgtNDA4NGY2YTMtMjc4NC00ZWFjLWE3ZjQtODc3YzI4NmNhZDVlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE1VDA2MDU1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU2OTFlMjBkMmYyY2M1NjQ5NGVkMjYwMWU2NjE3NjQyNTczYzgwNmZkY2I0NGFmYWRiZjhiM2E1MzRmYzYyNDcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.lCwJCrwDatTc6BrY0CPeg3VchX1gXsFj_vLMIooOx6w"){kind=link}