wolfboys commented on code in PR #4127:
URL:
https://github.com/apache/incubator-streampark/pull/4127#discussion_r1820794480
##########
streampark-console/streampark-console-service/src/main/assembly/conf/config.yaml:
##########
@@ -106,6 +106,10 @@ registry:
heartbeat-refresh-interval: 1s
session-timeout: 3s
+zookeeper:
Review Comment:
Directly configuring Zookeeper will confuse users, and they will need to
learn what it does. It is recommended to change to the following:
```
high-availability:
enable: false # true
# The list of ZooKeeper quorum peers that coordinate the
high-availability
# setup. This must be a list of the form:
# "host1:clientPort,host2:clientPort,..." (default clientPort: 2181)
#
zookeeper.quorum: 192.168.100.128:2181,192.168.100.129:2181
```
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/StreamParkConsoleBootstrap.java:
##########
@@ -48,11 +52,23 @@
@EnableScheduling
public class StreamParkConsoleBootstrap {
+ @Autowired
+ private RegistryService registryService;
+
public static void main(String[] args) throws Exception {
new SpringApplicationBuilder()
.properties(SpringProperties.get())
.sources(StreamParkConsoleBootstrap.class)
.run(args);
}
+ @PostConstruct
+ public void init() {
+ registryService.start();
Review Comment:
We need to decide whether to call this method based on the configuration
value "high-availability.enable."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@streampark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
