wolfboys commented on code in PR #4166:
URL:
https://github.com/apache/incubator-streampark/pull/4166#discussion_r1912414707
##########
streampark-common/src/main/java/org/apache/streampark/common/constants/Constants.java:
##########
@@ -51,6 +53,8 @@ private Constants() {
public static final String STREAMPARK_SPARKSQL_CLIENT_CLASS =
"org.apache.streampark.spark.cli.SqlClient";
+ public static final String STREAMPARK_FLINKCDC_CLIENT_CLASS =
"org.apache.streampark.cdc.cli.CDCClient";
Review Comment:
It is advisable to rename the package to
`org.apache.streampark.flink.cdc....`.
##########
streampark-common/src/main/scala/org/apache/streampark/common/util/PropertiesUtils.scala:
##########
@@ -101,6 +101,12 @@ object PropertiesUtils extends Logger {
}
}
+ def fromYamlTextToJava(text: String): java.util.Map[String, String] = {
Review Comment:
There is already a method:
[fromYamlTextAsJava](https://github.com/apache/incubator-streampark/blob/9c7387fcce3a19c6074d0eeb9d0979409c8529af/streampark-common/src/main/scala/org/apache/streampark/common/util/PropertiesUtils.scala#L212)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
