Lihe-Ma commented on code in PR #4194:
URL: https://github.com/apache/streampark/pull/4194#discussion_r1958100914
##########
streampark-flink/streampark-flink-packer/src/main/scala/org/apache/streampark/flink/packer/pipeline/impl/FlinkK8sApplicationBuildPipeline.scala:
##########
@@ -139,29 +148,33 @@ class FlinkK8sApplicationBuildPipeline(request:
FlinkK8sApplicationBuildRequest)
execStep(5) {
usingDockerClient {
dockerClient =>
- val pullImageCmd = {
- // when the register address prefix is explicitly identified on
base image tag,
- // the user's pre-saved docker register auth info would be used.
- val pullImageCmdState =
- dockerConf.registerAddress != null && !baseImageTag.startsWith(
- dockerConf.registerAddress)
- if (pullImageCmdState) {
- dockerClient.pullImageCmd(baseImageTag)
- } else {
- dockerClient
- .pullImageCmd(baseImageTag)
- .withAuthConfig(dockerConf.toAuthConf)
+ if (isImagePresent(dockerClient, baseImageTag)) {
Review Comment:
Thanks for your advice. I changed the code, it looks better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
