Copilot commented on code in PR #4223:
URL: https://github.com/apache/streampark/pull/4223#discussion_r2020054117
##########
k8s-yml/streampark-mysql.yml:
##########
@@ -0,0 +1,115 @@
+apiVersion: v1
+kind: ConfigMap
+metadata:
+ name: streampark-mysql-config
+ namespace: k8s-streampark
+data:
+ my.cnf: |
+ [mysqld]
+ pid-file = /var/run/mysqld/mysqld.pid
+ socket = /var/run/mysqld/mysqld.sock
+ datadir = /var/lib/mysql
+ secure-file-priv= NULL
+
Review Comment:
The configuration option 'secure-file-priv' appears to be incorrectly named;
it should likely be 'secure_file_priv' to match MySQL's expected parameter name.
```suggestion
secure_file_priv = NULL
```
##########
k8s-yml/streampark.yml:
##########
@@ -0,0 +1,92 @@
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ name: streampark
+ namespace: k8s-streampark
+spec:
+ replicas: 1
+ selector:
+ matchLabels:
+ app: streampark
+ template:
+ metadata:
+ labels:
+ app: streampark
+ spec:
+ containers:
+ - name: streampark-docker
+ image: ccr.ccs.tencentyun.com/huanghuanhui/streampark:2.1.5
+ imagePullPolicy: Always
+ ports:
+ - name: http
+ containerPort: 10000
+ command:
+ - /bin/sh
+ - -c
+ - |
+ export JAVA_HOME=/usr/lib/jvm/java-1.8-openjdk
+ /apache-streampark_2.12-2.1.5/bin/startup.sh
+ sleep 9999d
Review Comment:
[nitpick] Using 'sleep 9999d' to keep the container running is a
non-standard approach that could mask startup issues; consider implementing a
proper lifecycle management strategy or process supervision instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
