Copilot commented on code in PR #4261:
URL: https://github.com/apache/streampark/pull/4261#discussion_r2160049303
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SettingServiceImpl.java:
##########
@@ -79,10 +79,11 @@ public boolean update(Setting setting) {
.set(Setting::getSettingValue, value)
.update();
- getMavenConfig().updateConfig();
-
Optional<Setting> optional =
Optional.ofNullable(SETTINGS.get(setting.getSettingKey()));
optional.ifPresent(x -> x.setSettingValue(value));
+
+ getMavenConfig().updateConfig();
Review Comment:
Moving getMavenConfig().updateConfig() to after the SETTINGS update ensures
that the Maven configuration is updated with the latest settings, which
resolves the reported bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
