omkarparth commented on code in PR #4273:
URL: https://github.com/apache/streampark/pull/4273#discussion_r2248221976
##########
streampark-console/streampark-console-service/src/main/assembly/bin/streampark.sh:
##########
@@ -517,6 +519,13 @@ stop() {
fi
}
+jwt_secret() {
+ local secret=`$JAVACMD -cp "$APP_LIB/*" $BASH_UTIL --jwt_secret`
+ if [[ -n "$secret" ]]; then
+ echo "JWT_SECRET: $secret"
Review Comment:
Hi, I am the security researcher who reported the security issues which are
being fixed as part of this PR.
On the reviewing the changes, it looks like the encryption key is being
logged in service logs.
This is not recommended as it will create a footprint of the encryption key
in service logs. And anyone (including internal threat actors) who have access
to the service logs would be able to access the encryption key and decrypt the
JWT tokens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
