CuteShaos opened a new issue, #4278:
URL: https://github.com/apache/streampark/issues/4278

   ### Search before asking
   
   - [x] I had searched in the 
[issues](https://github.com/apache/streampark/issues?q=is%3Aissue+label%3A%22bug%22)
 and found no similar issues.
   
   
   ### Java Version
   
   1.8
   
   ### Scala Version
   
   2.12.x
   
   ### StreamPark Version
   
   2.1.5
   
   ### Flink Version
   
   1.19
   
   ### Deploy mode
   
   kubernetes-application
   
   ### What happened
   
   In the getFinalSavepointDir method, the processPath function is called but 
its return value is not assigned to any variable. This leads to the processed 
path being discarded, requiring the caller to call processPath again on the 
returned result. This causes:
   1. Redundant computation (same path processing executed twice)
   2. Inconsistent value handling (the method returns unprocessed value but 
expects it to be processed)
   3. Logical fragility (if processPath has side effects, they would occur 
twice)
   
   The current caller code shows this issue clearly:
   String customSavepoint = this.getFinalSavepointDir(savepointPath, 
application);
   if (StringUtils.isNotBlank(customSavepoint)) {
     customSavepoint = processPath(customSavepoint, application.getJobName(), 
application.getId());
   }
   
   ### Error Exception
   
   ```log
   
   ```
   
   ### Screenshots
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [x] Yes I am willing to submit a PR!(您是否要贡献这个PR?)
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@streampark.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to