Copilot commented on code in PR #4285:
URL: https://github.com/apache/streampark/pull/4285#discussion_r2335240509
##########
.github/workflows/docker-push.yml:
##########
@@ -18,12 +18,14 @@
name: "Build Docker Image"
on:
+ schedule:
+ - cron: '30 09 * * *'
+ timezone: 'Asia/Shanghai'
Review Comment:
The `timezone` field is not a valid property for GitHub Actions schedule
triggers. GitHub Actions cron schedules always run in UTC. To achieve the
desired behavior, adjust the cron expression to '30 01 * * *' (01:30 UTC =
09:30 Asia/Shanghai).
##########
.github/workflows/docker-push.yml:
##########
@@ -18,12 +18,14 @@
name: "Build Docker Image"
on:
+ schedule:
+ - cron: '30 09 * * *'
+ timezone: 'Asia/Shanghai'
push:
branches:
- release-*
- release:
- types:
- - released
+ tags:
+ - 'v[2-9]+.[0-9]+.[0-9]+'
Review Comment:
The regex pattern `v[2-9]+.[0-9]+.[0-9]+` is incorrect for semantic
versioning. The dots should be escaped as `\.` and the quantifier should be `*`
not `+` for the major version to allow single digits. Use
`'v[2-9]\.[0-9]+\.[0-9]+'` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@streampark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
