[ 
https://issues.apache.org/jira/browse/STREAMPIPES-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441948#comment-17441948
 ] 

Philipp Zehnder commented on STREAMPIPES-449:
---------------------------------------------

Hey, thanks a lot for your PR and sorry for the late reply.

The code looks good and I directly merged it. 

Currently we try to implement a test framework to test as many parts of the 
software with e2e tests, especially the pipeline elements. 

Therefore, test configurations can be defined, like in [1].

Would you be interested to provide such test descriptions for the processors 
that you just refactored?

 

[1] 
https://github.com/apache/incubator-streampipes/tree/dev/ui/cypress/fixtures/pipelineElement/filters-jvm/numericalFilter1

> Update Processing Element API in module streampipes-processors-filters-jvm
> --------------------------------------------------------------------------
>
>                 Key: STREAMPIPES-449
>                 URL: https://issues.apache.org/jira/browse/STREAMPIPES-449
>             Project: StreamPipes
>          Issue Type: Improvement
>          Components: Pipeline Elements
>            Reporter: Philipp Zehnder
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.69.0
>
>         Attachments: Screenshot from 2021-10-28 01-26-31.png, Screenshot from 
> 2021-10-28 01-27-33.png, Screenshot from 2021-10-28 20-11-27.png, Screenshot 
> from 2021-10-28 20-11-39.png, Screenshot from 2021-10-28 20-15-02.png
>
>
> The processors in this module use the old API, where 3 classes are required 
> for a single processing element. 
> These should be updated to use StreamPipesDataProcessor instead of 
> StreamPipesDataProcessor.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to