tenthe commented on issue #877: URL: https://github.com/apache/streampipes/issues/877#issuecomment-1371888500
Hi @aamirxshaikh, your suggestions looks good to me too. Regarding the last point, I agree with @bossenti. You can remove such empty methods. In general, we should add `implements` when a component implements a lifecycle hook. If the method is empty, we can safely delete it. @aamirxshaikh here is a link to Angular documentation that explains lifecycle hooks [link](https://angular.io/guide/lifecycle-hooks) Does the answer help you or do you have any unanswered questions? Thanks for your detailed descriptions 👌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
