muyangye commented on issue #1891: URL: https://github.com/apache/streampipes/issues/1891#issuecomment-1760185990
Hi I have pushed a PR that unit tests BooleanFilterProcessor. 2 quick concerns I have: - Does the directory structure seem good? Since no one has written any unit tests for module `streampipes-processors-filters-jvm` yet, I followed the directory structure convention of module `streampipes-processors-transformation-jvm` and created some new packages. I am not sure so please let me know the correct directory structure. - In order to test all filter processors, one needs to be able to tell the number of events being filtered. However, because SpOutputCollector is just an interface, one must define a class that implements the interface so that he can get the number of events. I followed the class in [this test](https://github.com/apache/streampipes/blob/ca4e0c2d44c1a713caaee3e9c1bff46096f41c53/streampipes-extensions/streampipes-processors-transformation-jvm/src/test/java/org/apache/streampipes/processors/transformation/jvm/processor/value/change/TestChangedValueDetectionProcessor.java) and I think other developers implementing unit tests for filter processors will probably do the same. Do you think it's a good idea to extract this class to make it commonly usable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
