muyangye commented on issue #1936: URL: https://github.com/apache/streampipes/issues/1936#issuecomment-1773972811
I have created a PR and tested it locally, it seemed to work for the first 2 enhancements. However, there are 3 concerns/questions I have: 1. For some reason, the text of the new dialog box (let users choose whether to delete all associated pipelines) is not aligned to center. I have tried to change CSS but it didn't work. The `fxLayoutAlign="center center"` also had no effect. How can I make it aligned to the center? 2. When deleting the pipeline, I first stop it and then delete it so that the Kafka consumer can be closed. But for adapter I did not stop it first. This is because in the original code the adapter is also not stopped. Is my approach correct? 3. #1960 says adapters can only be edited if no pipeline that uses the data stream is available so there's #1979. However, I did not encounter the issue (probably because I first deleted all associated pipelines and then the adapter) and did not use the WIP PR. I am wondering if the WIP PR will affect my PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
