[ http://issues.apache.org/struts/browse/WW-493?page=comments#action_37680 ]
Jason Carreira commented on WW-493: ----------------------------------- You might want to check with the Atlassian guys. I know they used to plug in to this config stuff for their products. You might just see what they need and make sure they can still do what they need with any new version. That's why we just left it the same as WebWork 1.x in 2.x. > Refactor Configuration classes > ------------------------------ > > Key: WW-493 > URL: http://issues.apache.org/struts/browse/WW-493 > Project: Struts 2 > Type: Improvement > Components: Configuration > Reporter: Bill Lynch > Assignee: Jason Carreira > Priority: Minor > Fix For: 2.0.0 > > The Configuration classes (see com\opensymphony\webwork\config\*.java) are > poorly designed and should be refactored. > Suggestions: > 1) Are there XWork classes we can use? Seems like the XWork configs should be > flexible enough to say something like "here are my config files, use them...". > 2) Move webwork.config.XMLActionConfiguration to > com.opensymphony.webwork.config.XMLActionConfiguration -- or use the XWork > XML config stuff (seems like it should be taken care of in there?). I don't > know why that class is in the webwork.config (old) package when it's pretty > integral to everything. > 3) Make Configuration abstract and fold in DefaultConfiguration into it. > There is no reason to have all the *Impl(..) methods when the class should > just be abstract anyway. All the code used in DefaultConfiguration can be > easily moved into Configuration. > 4) Remove get(String) method that returns an object. Is this even really > used? We should just stipulate that a property is a String only. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
