[ http://issues.apache.org/struts/browse/STR-2900?page=all ]
Wendy Smoak updated STR-2900:
-----------------------------
Attachment: frank_checkstyle.patch.gz
I asked Frank to zip his working copy and make it available. The attached
patch is the result of:
1. rename all _svn directories to .svn (TortoiseSVN .NET hack)
2. svn switch http://svn.apache.org/repos/asf/struts/struts1/trunk
(this was checked out when it was struts/action/trunk. svn switch also
does an update)
3. mvn clean install -Papps (which worked)
4. svn status | grep "C " (looking for conflicts, there were none)
5. svn diff > frank_checkstyle.patch
6. gzip frank_checkstyle.patch
> Checkstyle patches
> ------------------
>
> Key: STR-2900
> URL: http://issues.apache.org/struts/browse/STR-2900
> Project: Struts 1
> Type: Improvement
> Components: Apps, Core, EL, Extras, Faces, Scripting, Taglibs, Tiles
> Versions: 1.3.1
> Environment: Any
> Reporter: Frank W. Zammetti
> Assignee: James Mitchell
> Fix For: 1.3.5
> Attachments: all.patch, apps.zip, core.zip, el.zip, extras.zip, faces.zip,
> frank_checkstyle.patch.gz, integration.zip, mailreader-dao.zip,
> scripting.zip, taglib.zip, tiles.zip
>
> This is a collection of patches which addresses about 2,150 Checkstyle
> complaints. Each ZIP file should be unzipped, and be sure to recreate
> directory structure! You will find a structure that matches the source repo.
> I created a single patch file for each package within each subproject that
> has changes, so it should be quite granular enough. Also note that there are
> some new package.html files in some places which should be added. I will be
> happy to do another round once these are applied.
> For background, see also
> * http://www.mail-archive.com/dev%40struts.apache.org/msg22827.html
> * http://www.mail-archive.com/dev%40struts.apache.org/msg22988.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
