xhtml form-close-validate.ftl template has incorrect regex validation
---------------------------------------------------------------------
Key: WW-1419
URL: http://issues.apache.org/struts/browse/WW-1419
Project: Struts 2
Issue Type: Bug
Components: Views
Affects Versions: 2.0.0
Reporter: Josh Foure
In the template/xhtml/form-close-validate.ftl template, this is the code for
the regex validation:
if (field.value != null &&
!field.value.match("${validator.expression?js_string}")==null) {
addError(field, error);
errors = true;
}
Either the exclamation point in front of "field.value.match(...)" should be
removed or the "==null" after the match call should be removed. The problem
with having the "!" and the "==null" is that the left side will evaluate to a
boolean but any boolean compared to null is false.
This is what the code looks like in WebWorks 2.2.3 (they don't have the
"==null"):
if (field.value != null &&
!field.value.match("${validator.expression?js_string}")) {
addError(field, error);
errors = true;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
