[ http://issues.apache.org/struts/browse/STR-746?page=comments#action_38248 ] Niall Pemberton commented on STR-746: -------------------------------------
We've got into trouble in the past with tag pooling when attribute values are reset in the lifecycle methods of the tag. According to the servlet specification its up to the container when the attribute setters and reset methods are invoked - and the pooling strategy used is up to the implementation. In the case of the ParamTag the "value" property is being (re)set in the doAfterBody() method when the value is specified in the body and I believe this breaks the specification, since its the responsibility of the container and not the tag to set attribute values. Introducing a new instance variable which is initialized to the "value" property in the doStartTag and reset in the doAfterBody method if the tag has a body would I believe ensure that this doesn't cause problems. IMO it would also be a good idea to add a new page to the struts-examples webapp - always useful to be able to test tag functionality and to be able to point users asking how to use this new feature. > Add <html:param> for multiple parameters > ---------------------------------------- > > Key: STR-746 > URL: http://issues.apache.org/struts/browse/STR-746 > Project: Struts 1 > Issue Type: Improvement > Components: Taglibs > Affects Versions: Nightly Build > Environment: Operating System: All > Platform: All > Reporter: Jesse Blomberg > Assigned To: Paul Benedict > Priority: Minor > Fix For: 1.3.6 > > > Eric Fesler has an extension to the html:link tag. It allows nested param > tags > that allow the user to specify multiple parameters appended to the URI without > resorting to a map. Hopefully this could be incorporated into the next > release > of Struts. > Thanks, > Jesse Blomberg -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
