[ http://issues.apache.org/struts/browse/SB-44?page=comments#action_38431 ] Antonio Petrelli commented on SB-44: ------------------------------------
Attached a new version of the patch, created using Subclipse. I removed (hopefully) all formatting. This does not mean that files does not need formatting, but it should be done under a different JIRA issue. > TilesContextFactory should be a regular class > --------------------------------------------- > > Key: SB-44 > URL: http://issues.apache.org/struts/browse/SB-44 > Project: Sandbox > Issue Type: Improvement > Components: Tiles > Affects Versions: 2.0 > Environment: None > Reporter: Antonio Petrelli > Assigned To: David H. DeWolf > Attachments: tiles-context-factory-candidate-2.465236.patch, > tiles-context-factory.465236.patch > > > The org.apache.tiles.context.TilesContextFactory class should be a regular > class, not a class with only static methods. > This is because this object could eventually be replaced with another one > specified by the developer that uses Tiles, i.e. enhancing configuration. > Moreover, a class with only static methods should be only an "utility class", > thing that TilesContextFactory is not. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
