[ http://issues.apache.org/struts/browse/STR-1183?page=comments#action_38816 ] Mark Bakker commented on STR-1183: ----------------------------------
Last few days I have been looking into this issue. Untill now I did some exproring around the concerning classes. I am now about ready to start some coding. Based on code and comments input I think the requirements are; - There should be a ViewUtils class created with methods with parameters type ServletRequest, HttpSession, or ServletContext. Because this ViewUtils class shouldn't depend on any class in the struts-taglib subproject. I think it should be placed in the core project. "org.apache.struts.util" should be a nice place for this class - TagUtils class should depend on the ViewUtils class, and stay functional the same. I think some signatures of methodes must be changed, to avoid double code. The old methodes should become deprecated. If you guys have any remarks please let me know! > Add a generalized utililty class to expose information to non-JSP > presentation systems > -------------------------------------------------------------------------------------- > > Key: STR-1183 > URL: http://issues.apache.org/struts/browse/STR-1183 > Project: Struts 1 > Issue Type: Improvement > Components: Core > Affects Versions: Future > Environment: Operating System: All > Platform: All > Reporter: Anthony Kay > Assigned To: Struts Developers > Priority: Minor > Fix For: Future > > > Per the discussion RE Velocity Tools for Struts and the duplication of code in > RequestUtils for alternative presentation systems, I am proposing the > following > enhancement to the struts code base, which will allow the internal > configuration > information of Struts to be exposed while minimizing the dependencies that > have > to be written into presentation systems like Velocity Tools for Struts. > There was a suggestion (by T. Husted) that RequestUtils is really aimed at the > JSP layer, and after reviewing that interface, I agree that it is not the best > place to put this feature. I would suggest o.a.s.util.ViewUtils or something > similar. This RequestUtils class will end up needing some minor enhancement, > such as adding another overloaded entry into computeURL() that doesn't > require a > PageContext. > I plan to do an in-depth analysis of the tag libraries and general > configuration > systems of struts to come up with a general interface for ViewUtils, which I > will add to this entry as soon as I'm done. > Any suggestions as to what should be in this interface are more than welcome. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
