[ 
https://issues.apache.org/struts/browse/STR-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40094
 ] 

Paul Benedict commented on STR-2961:
------------------------------------

Henri, look at RequestProcessor.processPath line 739 to see the method which is 
the equivalent version. There is an empty String check there. So for some 
reason, that was not put into the 1.3 line. In my opinion, I say the fix is 
easy and should be done.

However, I am worried at the multiple path assignments in the method. There 
seems to be a lot of places an empty string could also show up. What do you 
think?

> SelectAction getPath returns null when used with URL rewriting and breaks 
> application
> -------------------------------------------------------------------------------------
>
>                 Key: STR-2961
>                 URL: https://issues.apache.org/struts/browse/STR-2961
>             Project: Struts 1
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.3.5
>         Environment: WebSphere Platform 6.0 [BASE 6.0.2.5 cf50549.21]  r
>            Reporter: Jill Nannizzi
>             Fix For: 1.3.7
>
>
> When I run with URL rewriting  enabled on my server I get  
> InvalidPathException("No action config found for the specified url.". Here is 
> the problem in SelectAction.getPath. The request.getPathInfo() returns an 
> empty string and the test on path == null stops the 2 further attempts to get 
> the servlet path. In the 1.2.4 RequestProcessor the statement
> "path = (String) request.getAttribute(INCLUDE_SERVLET_PATH);" is 
> unconditional so the problem does not happen.
> Here is the code in SelectAction:
>    if (path == null) {
>             path = request.getPathInfo();
>         }
>    // For extension matching, match on the servlet path
>         if (path == null) {
>             path =
>                 (String) request.getAttribute(Constants.INCLUDE_SERVLET_PATH);
>             if (path == null) {
>                 path = request.getServletPath();
>             }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to