[ 
https://issues.apache.org/struts/browse/STR-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40245
 ] 

Michael Jouravlev commented on STR-3006:
----------------------------------------

Seems that you believe that there is a policy to not fix taglib bugs. I hope 
that I was not the culprit of this misunderstanding. Apparently Martin Cooper 
got the same idea from my suggestion to deprecate (as in: to discourage from 
use and to freeze fixes to, not to remove) BEAN and LOGIC tags. He pointed out 
that there is no such policy.

Speaking for myself, I am indeed have no interest in fixing bugs in BEAN and 
and LOGIC tag libraries because this functionality is covered by JSTL, and JSTL 
is a bigger standard that Struts. In this regards I am not a worthy asset to 
Struts 1, despite that I was "brought in to help maintain an S1 project" and 
apparently was supposed to be dealing with such stuff. On the other hand, I am 
all for continuing working on HTML tags, for example it would be great to have 
Hubert's HTML2 stuff in core Struts taglib.

If you are sure that it won't break anything in other browsers nor in future 
versions of either MS or other browsers then it may be worth applying to 
taglib. I personally have nothing against arbitrary attributes but seems that I 
am in the minority. On another hand, if IE7 is buggy despite at least two years 
of development and testing and their claims of ensuring the outmost 
compatibility, isn't it their fault? Firefox seems to work fine ;-)

Anyway, it would be great if you submitted patches in CVS/SVN terms, that is, a 
diff file against known file version in SVN. Submitting 340K of modified 
struts-html.tld seems just too much.

> Struts HTML taglib's select element doesn't support proper onfocus events in 
> IE7
> --------------------------------------------------------------------------------
>
>                 Key: STR-3006
>                 URL: https://issues.apache.org/struts/browse/STR-3006
>             Project: Struts 1
>          Issue Type: Bug
>          Components: Taglibs
>    Affects Versions: 1.0 Final, 1.0.1, 1.0.1 Final, 1.0.2, 1.1.1, 1.2.2, 
> 1.2.4, 1.2.6 Beta, 1.2.7, 1.2.8, 1.2.9, 1.3.5, 1.3.6, 1.3.7, 1.4.0
>         Environment: Any
>            Reporter: Frank W. Zammetti
>            Priority: Minor
>         Attachments: BaseHandlerTag.java, struts-html.tld
>
>
> There is a known issue with IE7 and the plain <select> input element... let's 
> say for example you have this:
> <html>
>   <head>
>     <title></title>
>   </head>
>   <body>
>     <select onFocus="this.style.backgroundColor='#ff0000';">
>       <option value="1">1</option>
>       <option value="2">2</option>
>     </select>
>   </body>
> </html>
> In IE7, when you click on the dropdown arrow, the list of items will not 
> immediately show up, you need to click it twice.  This is due to the onFocus 
> handler being attached.  This is a known issue with IE.  The solution is to 
> simply add an onFocusIn handler which (usually) mimics the onFocus handler.
> However, in Struts 1, because the HTML taglib does not allow arbitrary 
> attributes (something I believe it should, and I said as much on a BugZilla 
> ticket which I can't seem to find in JIRA now, and along with it I suggested 
> adding a strictHTML attribute, which would default to true,  to allow (false) 
> or disallow (true) arbitrary attributes), you cannot properly deal with this 
> issue at present if you use the HTML taglib.
> Attached please find two updated files, BaseHandlerTag.java and 
> struts-html.tld, which adds support for the onfocusin attribute.
> I marked this as Minor, but for those of us dealing with this issue right 
> now, it's more like a Major :)  I also consider it a bug since I don't see 
> any viable work-around (someone can correct me if I'm wrong... and yes, not 
> using the HTML taglib is I suppose a valid answer, but I'd be looking for 
> something else)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to